-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow promos to be placed in the docs footer #3267
Allow promos to be placed in the docs footer #3267
Conversation
- this is in addition to the normal left navigation - works on the RTD and Alabaster themes
I'm not entirely sure what this CI error is but it seems unrelated. |
Yeah, I just resolved the error, feel free to merge/rebase. Changes look good! I'll dive into a review here shortly to look at the technical bits, but visually, everything fits neatly there. |
Looks good to me after a quick look over |
Got it running locally and 👍 |
Needs media to be compiled, but otherwise looks good |
I did generate |
Ah, nope! Sorry, just missed it in the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good! There are a few things where we shouldn't be hardcoding things -- the GA tracker id, english strings like "Sponsored" -- but we don't have a good pattern for either, or we're already doing both in other places anyways. I'll open up some new issues for those.
I'll rebase this and get it merged
* 'master' of github.com:rtfd/readthedocs.org: Add GLOBAL_PIP_CACHE setting (readthedocs#3299) Remove invalid attribute `exception` (readthedocs#3298) Update build from database at __exit__ (readthedocs#3292) Extra way to check OOM of a command ran inside Docker (readthedocs#3294) Add supervisord contrib example (readthedocs#3262) Allow promos to be placed in the docs footer (readthedocs#3267) Do not convert to bytes the `refresh_token` (readthedocs#3273)
This allows promos to be placed in the footer instead of the normal left navigation for both the RTD and Alabaster themes.